Tentacle upgrade (3.2.10->3.3.4) says success when it failed

Hi there

We’ve been trying to upgarde tentacles from 3.2.10 to 3.3.4, and the upgrade appears to succeed, but fails. See the attached log.

The relevant parts are:

09:19:18   Verbose  |     Octopus Deploy: Calamari version 3.3.4+Branch.master.Sha.9650e8092263e1eaee33b3af49a02d66d227ace2
09:19:53   Info     |     Running Tentacle version 3.2.10
09:20:33   Info     |     Waiting for Tentacle to shut down and restart with the new version 3.3.4...
09:35:40   Verbose  |     MSI (s) (AC:44) [09:22:26:804]: Product: Octopus Deploy Tentacle -- Error 1402. Could not open key: HKEY_CURRENT_USER\Software\Octopus\Tentacle.  System error 

1018.  Verify that you have sufficient access to that key, or contact your support personnel.
09:35:40   Verbose  |     Action ended 09:22:26: InstallFinalize. Return value 3.
09:35:40   Verbose  |     Action ended 09:22:26: INSTALL. Return value 3.
09:35:40   Verbose  |     CustomAction  returned actual error code 1603 (note this may not be 100% accurate if translation happened inside sandbox)
09:35:40   Verbose  |     Action ended 09:22:26: RemoveExistingProducts. Return value 3.
09:35:40   Verbose  |     Action ended 09:22:31: INSTALL. Return value 3.
09:35:40   Verbose  |     MSI (s) (AC:AC) [09:22:31:242]: Product: Octopus Deploy Tentacle -- Installation failed.
09:35:40   Verbose  |     MSI (s) (AC:AC) [09:22:31:258]: Windows Installer installed the product. Product Name: Octopus Deploy Tentacle. Product Version: 3.3.4. Product Language: 1033. 

Manufacturer: Octopus Deploy Pty. Ltd.. Installation success or error status: 1603.
09:35:53   Info     |     Running Tentacle version 3.2.10
09:35:54   Info     |     Running latest version of Calamari: 3.3.4
                    |   
                    |   == Success: Summary ==
09:35:54   Info     |     ONLINE:
09:35:54   Info     |     - [REDACTED] at poll://kyev4uynk252bnhjm7t7/, running version 3.2.10

ServerTasks-22345.log.txt (28 KB)

Hi Matt,

Thanks for getting in touch, and I’m sorry you’re having these issues.

So, according to the log, the user that the Tentacle is running as a local administer which should mean it has permissions to the Tentacle registry key, could you check the permissions on the Tentacle server to make sure the permissions haven’t been corrupted or changed…

I’ve raised #2468 to investigate making a change to how we treat failures when running the Tentacle MSI and if returns errors.

Thank you and best regards,
Henrik